From: Junio C Hamano Date: Tue, 05 Mar 2019 05:50:11 GMT Subject: Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible Message-ID: In-Reply-To: <20190304214155.GB3347@sigill.intra.peff.net> Jeff King writes: > This makes sense to me, though as you noted elsewhere, it doesn't fix > the gcrypt problem, since that file unconditionally wants to look at the > system gcrypt.h (and we control at the Makefile level whether we > actually look at sha256/gcrypt.h). Hmm, is that because the header check target does not know which *.h files we ship are actually used in a particular build? After a normal build, with dynamic dependency checking on, we would have sufficient information to figure it out. Would that help?