From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Jun 2019 15:21:36 GMT
Subject: Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant
Message-ID: <xmqqzhmdppmn.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cTXdz6s_cftPydKjtESz986s1xLQvwV8xPzYSR_xLK6Cg@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Tue, Jun 18, 2019 at 8:24 AM Jeff Hostetler via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> In MSVC, the DEBUG constant is set automatically whenever compiling with
>> debug information.
>>
>> This is clearly not what was intended in cache-tree.c, so let's use a less
>> ambiguous constant there.
>
> s/constant/macro name/ would be clearer.

It is closer to the standard-kosher terminology, I would think; if
somebody is in more pedantic mood, "C preprocessor macro" is
probably the phrase to use.