From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Feb 2020 21:02:49 GMT
Subject: Re: [PATCH 0/3] git-worktree: fix "add" being fooled by suffix matching
Message-ID: <xmqqzhd7og06.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200224090848.54321-1-sunshine@sunshineco.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Rather than adding more band-aids to the validation to work around magic
> matching performed by find_worktree(), this patch series fixes the
> problem once and for all by locating a worktree deterministically based
> only on pathname.

Makes sense.  I wonder if strange synonyms that make more than one
paths string refer to the same filesystem entity (read: case
insensitive or unicode smashing filesystems Windows and macintoshes
use) have similar effect on the codepath, and if so, if we want to
do anything about it (my personal answers are "I don't know but I
would not be surprised if it is the case" and "No, just tell users
not to hurt themselves and move on").

Will queue.  Thanks.