From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 Mar 2020 20:15:36 GMT
Subject: Re: [PATCH] trace2: teach Git to log environment variables
Message-ID: <xmqqzhc64yl3.fsf@gitster.c.googlers.com>
In-Reply-To: <aa4d22be-3710-1377-97aa-8ce8cfde0e20@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

>> As I mentioned in the commit message, I modeled this pretty closely on
>> the config parameter reporting code. It may make sense to split some of
>> this out into its own file, particularly the parts in trace2/tr2_cfg.c.
>> Alternatively, we could also just make the env var reporting part of the
>> config param reporting. Let me know if you have a preference either way.
>>
> Looks good to me.

Yup, thanks both.