From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 13 Aug 2020 17:46:40 GMT
Subject: Re: [PATCH v7 0/5] cleanup ra/rebase-i-more-options
Message-ID: <xmqqzh6y30cf.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2008131608240.54@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> I offered three small suggestions how I think it could be improved, still,
> but I would be pretty happy with seeing the patches moving to `next`
> as-are.

I tend to agree with those points I saw you mentioned.

The unconditional exporting of the committer-date without undoing
looked like a bad pattern waiting to be copied and pasted.  I
have not yet fully followed the codepath but I tend to agree with
your suspicion that commit_tree_extended() might be a better place
to do this.

Thanks.