From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 31 Aug 2020 20:42:24 GMT
Subject: Re: [PATCH v4] revision: add separate field for "-m" of "diff-index -m"
Message-ID: <xmqqzh6aeedr.fsf@gitster.c.googlers.com>
In-Reply-To: <20200831201422.27189-1-sorganov@gmail.com>

Sergey Organov <sorganov@gmail.com> writes:

> Add separate 'match_missing' field for diff-index to use and set it when we
> encounter "-m" option. This field won't then be cleared when another meaning of
> "-m" is reverted (e.g., by "--no-diff-merges"), nor it will be affected by
> future option(s) that might drive 'ignore_merges' field.
>
> Use this new field from diff-lib:do_oneway_diff() instead of reusing
> 'ignore_merges' field.
>
> Signed-off-by: Sergey Organov <sorganov@gmail.com>
> ---

Looks good.  Will queue.  Thanks.