From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 21 Sep 2020 16:05:26 GMT
Subject: Re: [PATCH v3 09/10] builtin/diff-tree: learn --merge-base
Message-ID: <xmqqzh5jf73t.fsf@gitster.c.googlers.com>
In-Reply-To: <20200920110148.GA227771@generichostname>

Denton Liu <liu.denton@gmail.com> writes:

> Hi Junio,
>
> On Fri, Sep 18, 2020 at 09:52:39AM -0700, Junio C Hamano wrote:
>> I wonder if turning the builtin/diff-tree.c to match that structure
>> make the result easier to understand (and I'll be perfectly happy if
>> the answer to this question turns out to be "no, the result of the
>> posted patch is the easiest to follow").
>
> git diff-tree does not even recognise ranges so as a result, the else
> case does not even need to exist there, unlike in git diff.

(caution: before morning caffeine so what I say may be totally off)

Do you mean "git diff-tree HEAD^..HEAD" would fail, or something
else?

Thanks.