From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 21 Jul 2023 14:10:50 GMT
Subject: Re: [PATCH] describe: fix --no-exact-match
Message-ID: <xmqqzg3pz76d.fsf@gitster.g>
In-Reply-To: <4eea7e15-6594-93e2-27b5-3d6e3c0baac6@web.de>

René Scharfe <l.s.r@web.de> writes:

> Since 2c33f75754 (Teach git-describe --exact-match to avoid expensive
> tag searches, 2008-02-24) git describe accepts --no-exact-match, but it
> does the same as --exact-match, an alias for --candidates=0.  That's
> because it's defined using OPT_SET_INT with a value of 0, which sets 0
> when negated as well.
>
> Let --no-exact-match set the number of candidates to the default value
> instead.  Users that need a more specific lack of exactitude can specify
> their preferred value using --candidates, as before.
>
> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> Or should we just forbid --no-exact-match?

We could do that, but setting it back to the default was also what I
did in my version I sent (<xmqqy1jcgbiv.fsf@gitster.g>) a few days
ago.