From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 02 May 2024 16:53:09 GMT
Subject: Re: [PATCH v5 7/7] refs: remove `create_symref` and associated dead code
Message-ID: <xmqqzft8dukq.fsf@gitster.g>
In-Reply-To: <ZjNFG5Ztnoj9DMzB@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

> On Wed, May 01, 2024 at 10:22:29PM +0200, Karthik Nayak wrote:
>> From: Karthik Nayak <karthik.188@gmail.com>
>> 
>> In the previous commits, we converted `refs_create_symref()` to utilize
>> transactions to perform symref updates. Earlier `refs_create_symref()`
>> used `create_symref()` to do the same.
>> 
>> This means, we can now remove `create_symref()` and any code associated
>> with it which is no longer used. We remove `create_symref()` code from
>> all the reference backends and also remove it entirely from the
>> `ref_storage_be` struct.
>
> Very nice.

Indeed.

The last paragraph reads well without "This means, ", by the way.