From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Aug 2024 18:43:53 GMT
Subject: Re: [RFC PATCH v3 3/7] t/clar: fix whitespace errors
Message-ID: <xmqqzfpg461i.fsf@gitster.g>
In-Reply-To: <03d601daed95$d10a63c0$731f2b40$@nexbridge.com>

<rsbecker@nexbridge.com> writes:

> On Tuesday, August 13, 2024 11:26 AM, Junio C Hamano wrote:
>>Patrick Steinhardt <ps@pks.im> writes:
>>
>>> Fix whitespace errors in the clar that make git-apply(1) unhappy. This
>>> has been cherry-picked from the upstream pull request at [1].
>>>
>>> [1]: https://github.com/clar-test/clar/pull/97
>>>
>>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>>> ---
>>>  t/unit-tests/clar/clar/sandbox.h  | 5 ++---
>>>  t/unit-tests/clar/generate.py     | 1 -
>>>  t/unit-tests/clar/test/.gitignore | 1 -
>>>  3 files changed, 2 insertions(+), 5 deletions(-)
>>
>>A funny thing about this step is that the copy I carried for the past few days was an
>>empty patch, because out of habit I use the "--whitespace=fix" option while running
>>"git am".  As that fixes the whitespace breakage this step addresses while applying
>>the previous step, this one becomes empty.
>>
>>I'll requeue these patches with --whitespace=warn instead.
>
> Please forgive the third ask, but I really want to test the build early. Suggestions?

Sorry, but I do not follow.  If you have "git am" and "git clone"
working, and if you have enough C toolchain to build the rest of
Git, wouldn't it be sufficient to also build this addition?  I think
the 7 patches cleanly apply to any recent tip of 'master'.