From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Jun 2025 19:15:53 GMT
Subject: Re: [PATCH v16 03/10] imap-send: gracefully fail if CRAM-MD5 authentication is requested without OpenSSL
Message-ID: <xmqqzfegpvyu.fsf@gitster.g>
In-Reply-To: <PN3PR01MB9597E68428E7483061E39A63B86BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

Aditya Garg <gargaditya08@live.com> writes:

> +				if (try_auth_method(srvc, ctx, imap, "CRAM-MD5", AUTH_CRAM_MD5, auth_cram_md5))
>  					goto bail;
> -				}
>  			} else {
>  				fprintf(stderr, "Unknown authentication method:%s\n", srvc->host);
>  				goto bail;

Outside the theme of this step (read: I am only leaving a mental
note as potential #leftoverbits; I do not want to see this fixed as
part of this step) and probably outside the theme of this series,
but srvc->host is probably copy-and-paste-bug for srvc->auth_method
I would think.