From: Junio C Hamano Date: Mon, 08 Jun 2026 12:06:33 GMT Subject: Re: [PATCH v3 0/8] setup: centralize object database creation Message-ID: In-Reply-To: Karthik Nayak writes: > Patrick Steinhardt writes: > >> Hi, >> >> this small patch series refactors the logic for how we discover and >> configure repositories. Most importantly, this involves the following >> two steps: >> >> 1. We unify the logic to apply the repository format, which is >> currently open-coded across multiple sites. These sites have >> already diverged, where some repository extensions are not >> consistently applied. >> >> 2. We then centralize creation of the object database to happen at the >> same time we apply the repository format. >> >> The end result is that we apply the repository format exactly once, and >> that's also the point in time where we can finalize the setup of the >> repo's data structures as we know about all details of the repo at that >> time. Ultimately, this makes it trivial to introduce the "objectStorage" >> extension, even though that's not part of this patch series. >> ... >> 4: 81b92bca7f = 4: b0d7c11fe6 repository: stop initializing the object database in `repo_set_gitdir()` >> 5: 807fc56353 = 5: d0af56fdae setup: stop creating the object database in `setup_git_env()` >> 6: 96563ff99f = 6: 3e75c5b0a6 setup: stop initializing object database without repository >> 7: c14f45169c = 7: 50fa2fdb3c repository: stop reading loose object map twice on repo init >> 8: e67c6e66d6 = 8: 4dff9d1794 setup: construct object database in `apply_repository_format()` >> > > The range-diff looks good and as expected. Thanks! Thanks, both of you. Let me mark the topic for 'next', then.