From: Junio C Hamano <jch@google.com>
Date: Thu, 19 Apr 2012 18:49:30 GMT
Subject: Re: [PATCH 8/9 v13] difftool: teach difftool to handle directory diffs
Message-ID: <xmqqy5prv9ol.fsf@junio.mtv.corp.google.com>
In-Reply-To: <CAFouetg6T1pgAiTfyAeSxseR-k_omsZDfqv8X8AifekwPLoE2g@mail.gmail.com>

Tim Henigan <tim.henigan@gmail.com> writes:

> I have a revised patch that prunes out all of the above and warns the
> user when it does so [1].

Thanks.

As long as it works when the user uses "two temporary trees" mode
without -M/-C, and it keeps working as well as before the change when
the user uses "one invocation per matched path" mode with -M/-C, I do
not care too deeply about how it is implemented in the script.

> However, it also prunes them when difftool is called in serial diff
> mode (i.e. non --dir-diff).

I do not use difftool myself, but I would imagine that it is a grave
regression, no?