From: Junio C Hamano Date: Wed, 14 May 2014 21:15:42 GMT Subject: Re: [PATCH] grep -I: do not bother to read known-binary files Message-ID: In-Reply-To: <20140514194128.GC2715@sigill.intra.peff.net> Jeff King writes: > On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote: > >> From: Johannes Schindelin >> Date: Mon, 8 Nov 2010 16:10:43 +0100 >> >> Incidentally, this makes grep -I respect the "binary" attribute (actually, >> the "-text" attribute, but "binary" implies that). >> >> Since the attributes are not thread-safe, we now need to switch off >> threading if -I was passed. >> >> Signed-off-by: Johannes Schindelin >> Signed-off-by: Stepan Kasal >> --- >> >> Hi, >> this patch has been in msysgit for 3.5 years. >> Stepan > > Hrm. Is this patch still necessary? In the time since this patch was > written, we did 0826579 (grep: load file data after checking > binary-ness, 2012-02-02), which should do the same thing. It deals with > the threading via a lock, but we later learned in 9dd5245 (grep: > pre-load userdiff drivers when threaded, 2012-02-02) to hoist that bit > out. Wow, power of Git history ;-) > So I suspect this patch at best is doing nothing, and at worst is > wasting extra time doing redundant attribute checks. Sounds like a sensible conclusion. Thanks. -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.