From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Jun 2014 21:37:45 GMT
Subject: Re: [PATCH v6 4/4] commit: Add commit.verbose configuration
Message-ID: <xmqqy4wvjjyu.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140617212132.GC13848@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Tue, Jun 17, 2014 at 02:39:00PM -0500, Caleb Thompson wrote:
>
>> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
>> index 35a4d06..471bd8f 100755
>> --- a/t/t7507-commit-verbose.sh
>> +++ b/t/t7507-commit-verbose.sh
>> @@ -7,6 +7,10 @@ write_script check-for-diff <<-'EOF'
>>  	exec grep '^diff --git' "$1"
>>  EOF
>>  
>> +write_script check-for-no-diff <<-'EOF'
>> +	! check-for-diff
>> +EOF
>
> Don't you need "$PWD/" or similar here, since check-for-diff is not in our path?

I actually would prefer a simpler

	! grep '^diff --git' "$1"

that does not depend on what other parts of the tests have done.