From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 15 Jun 2015 18:39:07 GMT
Subject: Re: [PATCH v2 08/12] initial_ref_transaction_commit(): function for initial ref creation
Message-ID: <xmqqy4jk95pw.fsf@gitster.dls.corp.google.com>
In-Reply-To: <19f421f504ae22538fd2a902840209c0799e67cb.1434206062.git.mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> It would seem to make sense to add a test here that there are no
> existing references, because that is how the function *should* be
> used. But in fact, the "testgit" remote helper appears to call it
> *after* having set up refs/remotes/<name>/HEAD and
> refs/remotes/<name>/master, so we can't be so strict.

Is "testgit" so hard to fix (or so sacred to break) that we want to
sacrifice the quality of this part that is nearer to the core?

> For now, the
> function trusts its caller to only call it when it makes sense. Future
> commits will add some more limited sanity checks.

OK.

Thanks.