From: Junio C Hamano Date: Thu, 05 May 2016 23:27:30 GMT Subject: Re: [PATCH] pathspec: remove check_path_for_gitlink Message-ID: In-Reply-To: Stefan Beller writes: >> I wonder if the patches mentioned have something to do with the "git >> add deep/in/the/tree" that fails to notice deep/in/ is an unrelated >> repository in some way? > > Which is considered a feature now. Maybe we should add tests for that? > > http://debuggable.com/posts/git-fake-submodules:4b563ee4-f3cc-4061-967e-0e48cbdd56cb That is a bug, plain and simple. Duy any ideas where we went wrong? I think we already have code to avoid adding beyond symlinks. "git add deep/in/the/tree" should refuse if deep/in is a symbolic link (and happens to point at a directory that has the/tree in it). We used not to catch that long time ago, but I think we fixed it. The logic and the places to do the checks for "no, that thing may be a directory but is an unrelated repository" should be the same.