From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Jun 2016 20:28:45 GMT
Subject: Re: [PATCH 3/4] commit: don't count i-t-a entries when checking if the new commit is empty
Message-ID: <xmqqy46iukn6.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqbn3ew0mf.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> I am wondering if this "we do not include status and do not ask
> run_status() about commitable bit" codepath should share more with
> the other side, which you do not touch at all with this series,
> which in turn must be doing the right thing already, apparently
> without having to know anything about the SHIFT_INTENT_TO_ADD
> hackery.
>
> Or does "git commit" that uses run_status() still allow an empty
> commit after this patch?

Ah, I didn't see what 2/4 does.  The duplication still does make
this look an ugly hack, but I can see that the series is at least
internally consistent.