From: Junio C Hamano Date: Mon, 11 Jul 2016 19:19:42 GMT Subject: Re: [PATCH v4 0/6] convert various shell functions in git-bisect to C Message-ID: In-Reply-To: <20160706202523.9850-1-pranit.bauva@gmail.com> Pranit Bauva writes: > Some minor nits. Previous version can be found here[1]. > > [1]: http://thread.gmane.org/gmane.comp.version-control.git/298263 > > The inter-diff is : > ... > diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c > ... > Pranit Bauva (6): > bisect--helper: `bisect_clean_state` shell function in C > t6030: explicitly test for bisection cleanup > wrapper: move is_empty_file() and rename it as > is_empty_or_missing_file() > bisect--helper: `bisect_reset` shell function in C > bisect--helper: `is_expected_rev` & `check_expected_revs` shell > function in C > bisect--helper: `bisect_write` shell function in C > > builtin/am.c | 20 +--- > builtin/bisect--helper.c | 220 +++++++++++++++++++++++++++++++++++++++++++- > cache.h | 3 + > git-bisect.sh | 97 ++----------------- > t/t6030-bisect-porcelain.sh | 17 ++++ > wrapper.c | 13 +++ > 6 files changed, 261 insertions(+), 109 deletions(-) Will replace. Thanks.