From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 18 Jul 2016 19:17:44 GMT
Subject: Re: [PATCH] test-lib: stricter unzip(1) check
Message-ID: <xmqqy44yiwmf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160718185634.GA24726@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Jul 18, 2016 at 11:20:19AM -0700, Junio C Hamano wrote:
>
>> Stepping back a bit, why do we even care if "unzip -a" works on
>> "../$zipfile" and converts things correctly in that check_zip() test
>> in t5003 in the first place?  It looks more like a test on "unzip"
>> than making sure we correctly generate a zip archive to me...
>
> I think it is testing that we generated an archive with the correct "I
> am text" flags so that an unzip implementation can do the
> auto-conversion.

Yes, I understand that.  I was hoping for a response along the lines
of "we want to make sure we mark text as text, and 'zip -l' has an
option to let us check the attributes without having to actually
checking things out" ;-)