From: Junio C Hamano Date: Wed, 21 Sep 2016 18:01:12 GMT Subject: Re: [PATCH 3/3] gitweb: Link to "git describe"'d commits in log messages Message-ID: In-Reply-To: Jakub Narębski writes: >> When I saw 2/3 I wondered about one thing and 3/3 shares the same, >> which is that we only use regex match and do not validate for a >> false match. Would it be too expensive... > > It's a matter of balance between false positives (and unresolving > links) and performance... Yes, and that is why I asked a simple yes-or-no question. Would it be too expensive? Your answer seems to be yes. Have we measured? Is that really a bottleneck? Would it help to update parse_commits to call a new command "gitweb--helper" that produces the result of what git_print_log would have done to its $log argument, for example?