From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Jul 2017 23:11:12 GMT
Subject: Re: [PATCH 21/28] commit_packed_refs(): use a staging file separate from the lockfile
Message-ID: <xmqqy3riiu0f.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <2779ee9a75e75ff80898e51e46d561b8074e0dc2.1497534157.git.mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> We will want to be able to hold the lockfile for `packed-refs` even
> after we have activated the new values. So use a separate tempfile,
> `packed-refs.new`, as a place to stage the new contents of the
> `packed-refs` file. For now this is all done within
> `commit_packed_refs()`, but that will change shortly.
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---

The layout created by "contrib/workdir/git-new-workdir" will be
broken by this line of change.  "git worktree" is supposed to know
that refs/packed-refs is a shared thing and lives in common-dir,
so it shouldn't be affected.

Do we care about the ancient layout that used symlinks to emulate
the more modern worktree one?