From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Jul 2018 21:44:10 GMT
Subject: Re: [PATCH v2 6/6] submodule--helper: introduce new update-module-mode helper
Message-ID: <xmqqy3e9leqd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180717075959.30594-1-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

>> +	fprintf(stdout, submodule_strategy_to_string(&update_strategy));
>
> Various compilers warn about the potential insecurity of the above
> call:
>
>       CC builtin/submodule--helper.o
>   builtin/submodule--helper.c: In function ‘module_update_module_mode’:
>   builtin/submodule--helper.c:1502:2: error: format not a string literal and no format arguments [-Werror=format-security]
>     fprintf(stdout, submodule_strategy_to_string(&update_strategy));
>     ^
>   cc1: all warnings being treated as errors
>   Makefile:2261: recipe for target 'builtin/submodule--helper.o' failed
>   make: *** [builtin/submodule--helper.o] Error 1
>
> I think it should either use an explicit format string:
>
>   fprintf(stdout, "%s", submodule_strategy_to_string(&update_strategy));
>
> or, perhaps better yet, simply use fputs().

Sounds good.