From: Junio C Hamano Date: Mon, 19 Aug 2019 17:17:32 GMT Subject: Re: [PATCH v4 21/24] merge-recursive: split internal fields into a separate struct Message-ID: In-Reply-To: <20190817184144.32179-22-newren@gmail.com> Elijah Newren writes: > merge_options has several internal fields that should not be set or read > by external callers. This just complicates the API. Move them into an > opaque merge_options_internal struct that is defined only in > merge-recursive.c and keep these out of merge-recursive.h. Makes quite a lot of sense. Thanks.