From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 15 Oct 2019 01:35:37 GMT
Subject: Re: [PATCH v4] stash: avoid recursive hard reset on submodules
Message-ID: <xmqqy2xmdc46.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191012153829.GB743557@OJAN-PAAVO.localdomain>

Jakob Jarmar <jakob.j@gmail.com> writes:

> git stash push does not recursively stash submodules, but if
> submodule.recurse is set, it may recursively reset --hard them. Having
> only the destructive action recurse is likely to be surprising
> behaviour, and unlikely to be desirable, so the easiest fix should be to
> ensure that the call to git reset --hard never recurses into submodules.
>
> This matches the behavior of check_changes_tracked_files, which ignores
> submodules.
>
> Signed-off-by: Jakob Jarmar <jakob@jarmar.se>
> ---
>
> Notes:
>     1. Added space between function name and parentheses
>     2. Moved test_when_finished cleanup to top of setup_basic

Looks good; will queue.

Thanks.