From: Junio C Hamano Date: Mon, 06 Apr 2020 23:46:28 GMT Subject: Re: [PATCH 1/2] gitfaq: cleanup gitfaq.txt Message-ID: In-Reply-To: <20200406181216.5340-2-shouryashukla.oo@gmail.com> Shourya Shukla writes: [jc: All other changes in 1/2 turned out to be removal of SP when there were dot-SP-SP at the end of a sentence, which I am omitted here as they were so distracting.] > -Such a shell command can be specified by starting the option value with an > -exclamation point. If your password or token were stored in the `GIT_TOKEN`, > +Such a shell command can be specified by putting an exclamation point before > +the option. If your password or token were stored in the `GIT_TOKEN`, > you could run the following command to set your credential helper: Sorry, but I am not sure how this change is an improvement. It is not making it worse, but it is not making it any better, at least to me. > -How do I ignore changes to a tracked file?:: > - Git doesn't provide a way to do this. The reason is that if Git needs > +How do I ignore changes made to a tracked file?:: > + Git doesn't provide a way to do this. The reason is that if Git needs Ah, strike what I said about your new section on ".gitignore"; this is already the right place to describe it. With or without 'made', I think the header says the same thing, but I guess it does not hurt to be explicit. By the way, if you still want to pursue "full-stop at the end of the sentence MUST be followed by no more than one SP", I won't stop you, but please do so in a separate patch that has NO OTHER CHANGES. They drown other changes out that are not mechanical and makes them hard to review. Thanks.