From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 24 May 2020 16:32:44 GMT
Subject: Re: [PATCH v3 4/5] rebase -i: support --ignore-date
Message-ID: <xmqqy2phpa37.fsf@gitster.c.googlers.com>
In-Reply-To: <20200523155203.GA10163@danh.dev>

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

>> > I think there're some grep out there considers file doesn't end with
>> > newline as non-text files.
>> 
>> Yes it would be better to print the newline, thanks
>>
>> Junio - are you happy to fix this up (assuming there are no other issues) or
>> do you want a re-roll?
>
> There're 11 invocation of git-log with "--pretty=format",
> in 2/5 and 4/5
>
> I think it's worth to have a re-roll to avoid mistake.

It would be appropriate to send "[PATCH v3 6/5] fixup! ..." if the
fix needs to be made only to a single step.  It would be the least
error-prone approach.

Thanks.