From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 24 Mar 2022 04:53:05 GMT
Subject: Re: [PATCH v2 08/27] revisions API users: use release_revisions() needing "{ 0 }" init
Message-ID: <xmqqy210kl3i.fsf@gitster.g>
In-Reply-To: <patch-v2-08.27-42ad1208934-20220323T203149Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Use release_revisions() to various users of "struct rev_list" which
> need to have their "struct rev_info" zero-initialized before we can
> start using it. In all of these cases we might "goto cleanup" (or equivalent),

I didn't look at the bisect code, but the bundle one looks iffy from
the point of view of API cleanliness.  If we have not yet called
repo_init_revisions() on a revs, we should refrain from calling
release_revisions() on it in the first place, no?