From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 08 Feb 2023 21:12:35 GMT
Subject: Re: [PATCH v2 3/5] hook API: support passing stdin to hooks, convert am's 'post-rewrite'
Message-ID: <xmqqy1p7q2t8.fsf@gitster.g>
In-Reply-To: <patch-v2-3.5-3d3dd6b900a-20230208T191924Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> From: Emily Shaffer <emilyshaffer@google.com>
>
> Convert the invocation of the 'post-rewrite' hook run by 'git am' to
> use the hook.h library. To do this we need to add a "path_to_stdin"
> member to "struct run_hooks_opt".
>
> In our API this is supported by asking for a file path, rather
> than by reading stdin. Reading directly from stdin would involve caching
> the entire stdin (to memory or to disk) once the hook API is made to
> support "jobs" larger than 1, along with support for executing N hooks
> at a time (i.e. the upcoming config-based hooks).

OK, that is a sensible plan to spool and dup/tee the input to
children.  It may not be necessary yet at this step, but it is very
good to be thinking ahead.

Looking good.