From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 29 Mar 2023 21:48:32 GMT
Subject: Re: [PATCH v7 3/4] notes.c: introduce '--separator=<paragraph-break>' option
Message-ID: <xmqqy1nf8c0f.fsf@gitster.g>
In-Reply-To: <20230329141559.14244-1-tenglong.tl@alibaba-inc.com>

Teng Long <dyroneteng@gmail.com> writes:

>> > diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
>> > index 3288aaec..716192b5 100755
>> > --- a/t/t3301-notes.sh
>> > +++ b/t/t3301-notes.sh
>> > @@ -5,6 +5,7 @@
>> >
>> >  test_description='Test commit notes'
>> >
>> > +TEST_PASSES_SANITIZE_LEAK=true
>> >  . ./test-lib.sh
>>
>> This is a strange commit to add this.  If the test and the code
>> involved in the test were leak-sanitizer clean before this commit,
>> then you should have been able to insert this without any other
>> change, and we should do it that way in a separate commit.  If we
>> are fixing an existing leak that the sanitizer complains, then that
>> is a different matter.  If that is the case, it makes perfect sense
>> to have this here, but the proposed commit log message should
>> explain that it is what is happening.
>
> Will fix.

Thanks.

Just FYI, it seems that it is indeed premature to declare that this
one to be leak-free.  With this topic merged to 'seen', the leak
checker CI job seems to choke on t3301 (in addition, it also barfs
on t3307).

https://github.com/git/git/actions/runs/4557669485/jobs/8039614419#step:4:1817