From: Junio C Hamano Date: Mon, 30 Oct 2023 23:53:57 GMT Subject: Re: [RFC PATCH 1/3] strbuf: make add_lines() public Message-ID: In-Reply-To: Jonathan Tan writes: > Subsequent patches will require the ability to add different prefixes > to different lines (depending on their contents), so make this > functionality available from outside strbuf.c. I do not think it is a good idea to force almost everybody to repeat themselves. As we can see here, all but just a single caller of strbuf_add_lines() with this patch pass the same prefix for both parameters. If we need to make the current strbuf.c:add_lines() also available to some specific callers, that is fine, but let's keep the simpler version that almost everybody uses as-is, and give the more complex and featureful one that is used only by selected callers a longer and more cumbersome name. Thanks.