From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 May 2024 20:33:09 GMT
Subject: Re: [PATCH v2 2/4] t1517: test commands that are designed to be run outside repository
Message-ID: <xmqqy18de9kq.fsf@gitster.g>
In-Reply-To: <CAO_smVg7mdQHp+sg4-vVUEOVRBEoZjqXZu=Kk8PuYc9mtYeMXg@mail.gmail.com>

Kyle Lippincott <spectral@google.com> writes:

> Do we only expect failure because of a temporary condition (the bug
> that is mentioned in the commit message)? If so, we should probably
> add a TODO, FIXME, or some other similar style of comment that
> describes that this should be fixed.

test_expect_failure is description enough for that purpose.

If a command should NOT work outside the project we will write a
test more like so:

	test_expect_success 'foo does not work outside' '
		... prepare that $cwd is outside ...
		test_must_fail git foo
	'