From: Junio C Hamano Date: Thu, 30 May 2024 14:33:34 GMT Subject: Re: [GSoC][PATCH v3 0/4] t: port reftable/basics_test.c to the unit testing Message-ID: In-Reply-To: Christian Couder writes: > On Thu, May 30, 2024 at 6:36 AM Patrick Steinhardt wrote: >> >> On Wed, May 29, 2024 at 10:29:26PM +0530, Chandra Pratap wrote: >> > In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit >> > testing framework written entirely in C was introduced to the Git project >> > aimed at simplifying testing and reducing test run times. >> > Currently, tests for the reftable refs-backend are performed by a custom >> > testing framework defined by reftable/test_framework.{c, h}. Port >> > reftable/basics_test.c to the unit testing framework and improve upon >> > the ported test. >> > >> > Mentored-by: Patrick Steinhardt >> > Mentored-by: Christian Couder >> > Signed-off-by: Chandra Pratap >> >> This version looks good to me, thanks! > > It looks good to me too. Thanks, all. Queued.