From: Junio C Hamano Date: Mon, 10 Jun 2024 16:15:04 GMT Subject: Re: [PATCH 1/4] __attribute__: trace2_region_enter_printf() is like "printf" Message-ID: In-Reply-To: Patrick Steinhardt writes: > On Sat, Jun 08, 2024 at 11:37:44AM -0700, Junio C Hamano wrote: >> The last part of the parameter list the function takes is like >> parameters to printf. mark it as such. > > s/mark/Mark, or convert the dot to a semicolon. > >> An existing call that formats a value of type size_t using "%d" was >> found by the compiler with the help with this annotation; fix it. > > Makes sense, as do all the other patches in this series. Thanks, will amend.