From: Junio C Hamano Date: Tue, 26 Nov 2024 19:27:33 GMT Subject: Re: [PATCH v2] builtin: allow passing custom data to sub-commands Message-ID: In-Reply-To: karthik nayak writes: > Could you elaborate on why you think this is an over-optimization? We > don't loose functionality with this, nor do we have to have add > additional code to handle the typecasting to `struct repository *` if > needed. But would definitely like to resolve anything I missed. I do not know if it is an optimization, but if you know it is of a specific type, casting back and force with "void *" loses type safety, no?