From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 Jul 2025 15:06:03 GMT
Subject: Re: [PATCH v5 3/4] bloom: replace struct bloom_key * with struct bloom_keyvec
Message-ID: <xmqqy0su3gys.fsf@gitster.g>
In-Reply-To: <1B012532-E1B3-43CE-871B-B850D86419B1@smail.nju.edu.cn>

Lidong Yan <502024330056@smail.nju.edu.cn> writes:

> Junio C Hamano <gitster@pobox.com> write:
>> 
>> Lidong Yan <yldhome2d2@gmail.com> writes:
>> 
>>> static void prepare_to_use_bloom_filter(struct rev_info *revs)
>>> {
>>> struct pathspec_item *pi;
>>> + struct bloom_keyvec *bloom_keyvec;
>> 
>> This new variable is no longer used, since the code to create a new
>> keyvec is in a helper function and its return value is directly
>> stored in the array of keyvecs.
>> 
>>> char *path_alloc = NULL;
>>> const char *path, *p;
>> 
>> And the "p" variable no longer is used, because the logic it used to
>> create a new keyvec is moved elsewhere.
>
> Will fix in v6, Thanks,

FWIW, what I queued have these two already removed from v5.

Thanks.