From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 08 Sep 2026 17:49:15 GMT
Subject: Re: [PATCH v2 2/5] setup: extract path_allowlist_apply()
Message-ID: <xmqqy0dbws4k.fsf@gitster.g>
In-Reply-To: <CAP8UFD0qSA_giG1o8ydwxUOyscQaJ9pSNyngCdC7OEa7G_C5jA@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> path_allowlist_apply(key, value, data->path, &data->is_safe);
>
> But OK, I have changed both `int is_match` and `int is_safe` to `bool
> matches` and `bool safe` in the v3 I just sent.

I hate to say this but I think is_safe was perfectly good.  is_match
was not quite grammatrical (it is either "matches" ir "is_a_match"),
but "is_safe" is perfectly fine.