From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 12 Sep 2013 15:48:15 GMT
Subject: Re: [PATCH 1/2] relative_path should honor dos_drive_prefix
Message-ID: <xmqqwqmmoxc0.fsf@gitster.dls.corp.google.com>
In-Reply-To: <5231CBFA.3070806@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

>> +static int have_same_root(const char *path1, const char *path2)
>> +{
>> +	int is_abs1, is_abs2;
>> +
>> +	is_abs1 = is_absolute_path(path1);
>> +	is_abs2 = is_absolute_path(path2);
>> +	return (is_abs1 && is_abs2 && !strncasecmp(path1, path2, 1)) ||
>                                        ^^^^^^^^^^^
> I wonder: should strncasecmp() be replaced with strncmp_icase() ?

True.

> See dir.c: 
> int strncmp_icase(const char *a, const char *b, size_t count)
> {
> 	return ignore_case ? strncasecmp(a, b, count) : strncmp(a, b, count);
> }