From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 19 Sep 2014 17:52:50 GMT
Subject: Re: [PATCH v2] refs: make rev-parse --quiet actually quiet
Message-ID: <xmqqwq8zmr9p.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1411098337-35406-1-git-send-email-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

> When a reflog is deleted, e.g. when "git stash" clears its stashes,
> "git rev-parse --verify --quiet" dies:
>
> 	fatal: Log for refs/stash is empty.
>
> The reason is that the get_sha1() code path does not allow us
> to suppress this message.
>
> Pass the flags bitfield through get_sha1_with_context() so that
> read_ref_at() can suppress the message.
>
> Use get_sha1_with_context1() instead of get_sha1() in rev-parse
> so that the --quiet flag is honored.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> This is a replacement patch for "refs: make rev-parse --quiet actually quiet"
> from da/rev-parse-verify-quiet in pu.

Looks good; thanks.