From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 03 Oct 2014 22:12:42 GMT
Subject: Re: [PATCH 07/16] t5304: use test_path_is_* instead of "test -f"
Message-ID: <xmqqwq8gkdk5.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141003202512.GG16293@peff.net>

Jeff King <peff@peff.net> writes:

> This is slightly more robust (checking "! test -f" would not
> notice a directory of the same name, though that is not
> likely to happen here). It also makes debugging easier, as
> the test script will output a message on failure.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This patch is totally optional. I did it while debugging t5304 (strange
> how badly prune works when you accidentally invert the mtime check!)
> and figured it might be worth keeping as a cleanup.

Looks sensible; thanks.