From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Feb 2016 21:19:31 GMT
Subject: Re: [PATCHv19 00/11] Expose submodule parallelism to the user
Message-ID: <xmqqwppn8ba4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kY5nxDQ_o0L_MOYFOx4FPH1apW-TuB88UypuwDaLuKGNQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> Maybe we want to remove the struct child_process from the
> function signature of the callbacks and callbacks need to rely on
> the data provided solely thru the pointer as passed around for
> callback purposes, which the user is free to use for any kind
> of data.

I think that is the most sensible.

> As a rather quickfix for 2.8 (and 2.7) we could however just
> breakup the finish_command function and call child_process_clear
> after the callbacks have run.

That would not fix the case where run_command() fails, clears child
and then start failure callback, no?