From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 22 Mar 2016 17:12:00 GMT
Subject: Re: [PATCH v2] branch -D: allow - as abbreviation of '@{-1}'
Message-ID: <xmqqwpouigin.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq1t72jvac.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> I _think_ strbuf_branchname() leaves "@{-<N>}" when you do not have
> enough branch switches in the reflog, so perhaps ...

This is a tangent, but the value returned from strbuf_branchname()
is not well documented, and nobody looks at it.  It might not be a
bad idea to change the return value from the function in such a way
that it can signal "I saw @{-<N>} syntax but there weren't enough
branch switches" and also "I saw branch@{upstream} syntax but that
branch does not have an upstream configured for it" to its callers.

That way, the suggested "perhaps like this..." patch does not have
to do an ugly hack: if (starts_with(bname.buf, "@{-")).