From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 28 Jul 2016 16:12:33 GMT
Subject: Re: [PATCH v2] i18n: config: unfold error messages marked for translation
Message-ID: <xmqqwpk5spvy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1469711643-10367-1-git-send-email-vascomalmeida@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

> Unfold the message into several templates for each known origin_type.
> That would result in better translation at the expense of code
> verbosity.

Looks good now, except one minor nit I'll tweak out while queuing.

>  	if (cf->die_on_error)
> -		die(_("bad config line %d in %s %s"), cf->linenr, cf->origin_type, cf->name);
> +		die("%s", error_msg);
>  	else
> -		return error(_("bad config line %d in %s %s"), cf->linenr, cf->origin_type, cf->name);
> +		error_return =  error("%s", error_msg);

s/ =  / = /;

Thanks.