From: Junio C Hamano Date: Wed, 24 Oct 2018 03:10:39 GMT Subject: Re: [PATCH 1/3] gpg-interface.c: use flags to determine key/signer info presence Message-ID: In-Reply-To: <20181023225605.GB6119@genre.crustytoothpaste.net> "brian m. carlson" writes: > On Mon, Oct 22, 2018 at 06:38:19PM +0200, Michał Górny wrote: >> Replace the logic used to determine whether key and signer information >> is present to use explicit flags in sigcheck_gpg_status[] array. This >> is more future-proof, since it makes it possible to add additional >> statuses without having to explicitly update the conditions. > > This series looks good to me. I was going to ask after patch 2 whether > you were printing the subkey or primary key fingerprint, and then you > answered my question in patch 3. Thanks for including both. Yeah, this looks good to me too. Thanks, both.