From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 02 Oct 2019 05:38:24 GMT
Subject: Re: [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip>
Message-ID: <xmqqwodng10v.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2de6b236-7bd8-256b-7d8f-911d63a47498@gmail.com>

William Baker <williamtbakeremail@gmail.com> writes:

> I saw that the code base is currently a mix of #define and enums when it
> comes to flags  (e.g. dir_struct.flags and rebase_options.flags are both
> enums) and so using one here would not be something new stylistically.

Yes.  But it is a different matter to spread a bad practice to
parts of the code that haven't been contaminated by it.