From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 20 Dec 2019 19:28:02 GMT
Subject: Re: [PATCH 1/2] am: pay attention to user-defined context size
Message-ID: <xmqqwoaq94ql.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <e1870f3fee8be6ebbecdd618ae1803afb878e67e.1576868036.git.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Elijah Newren <newren@gmail.com>
>
> am previously only checked gpg-related config options and the default
> config options while ignoring any diff-related options.  This meant that
> when users tried to set diff.context to something larger than the
> default value of 3, it was ignored.  Pay attention to the diff settings
> too.

Can the benefit brought in by this change demonstrated by a new test
or two?


Puzzled.  "am" accepts whatever patch somebody else prepared and
has no control over how the incoming "diff" was produced by that
somebody else.  

Besides, I do not think it should be affected by any diff_*UI*_config()
in the first place.