From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Feb 2021 21:41:25 GMT
Subject: Re: [PATCH v2 09/11] t/t3437: cleanup the 'setup' test and use named commits in the tests
Message-ID: <xmqqwnvi44qi.fsf@gitster.c.googlers.com>
In-Reply-To: <20210208192528.21399-10-charvi077@gmail.com>

Charvi Mendiratta <charvi077@gmail.com> writes:

> Remove unnecessary curly braces and use the named commits in the
> tests so that they will still refer to the same commit if the setup
> gets changed in the future whereas 'branch~2' will change which commit
> it points to.

Doing two things in the same commit?  I think ${EMPTY} thing is a
general style clean-up, while tagging is a bit more meaningful
change to make it easier to understand tests and is a change at a
more conceptual level.  The ${EMPTY} change would be better done at
the same time when the here document was cleaned up in [v2 05/11],
I would think.

Thanks.