From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 01 Jul 2021 19:55:08 GMT
Subject: Re: [PATCH 14/15] [GSOC] cat-file: re-implement --textconv, --filters options
Message-ID: <xmqqwnq9reqr.fsf@gitster.g>
In-Reply-To: <3aeb4d3d3ec9dc112a19a8b4adeaf213577b4028.1625155693.git.gitgitgadget@gmail.com>

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +#define USE_THE_INDEX_COMPATIBILITY_MACROS
>  #include "builtin.h"
>  #include "cache.h"
>  #include "parse-options.h"
> @@ -84,6 +85,9 @@ static struct expand_data {
>  	struct object_info info;
>  } oi, oi_deref;
>  
> +int use_filters;
> +int use_textconv;

With this commit in, "make sparse" dies like so:

    SP ref-filter.c
ref-filter.c:88:5: error: symbol 'use_filters' was not declared. Should it be static?
ref-filter.c:89:5: error: symbol 'use_textconv' was not declared. Should it be static?