From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 08 Oct 2021 09:04:14 GMT
Subject: Re: [PATCH 3/3] read-cache: let verify_path() reject trailing dir separators again
Message-ID: <xmqqwnmnlwfl.fsf@gitster.g>
In-Reply-To: <5e6fafa9-f155-61af-6906-05fec27808e6@web.de>

René Scharfe <l.s.r@web.de> writes:

> 6e773527b6 (sparse-index: convert from full to sparse, 2021-03-30) made
> verify_path() accept trailing directory separators for directories,
> which is necessary for sparse directory entries.  This clemency causes
> "git stash" to stumble over sub-repositories, though, and there may be
> more unintended side-effects.
>
> Avoid them by restoring the old verify_path() behavior and accepting
> trailing directory separators only in places that are supposed to handle
> sparse directory entries.
>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  read-cache.c                       | 6 +++---
>  t/t3905-stash-include-untracked.sh | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)

Makes sense.  Thanks.