From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Dec 2022 22:19:27 GMT
Subject: Re: [PATCH v4 0/9] Get rid of "git --super-prefix"
Message-ID: <xmqqwn6sqphs.fsf@gitster.g>
In-Reply-To: <kl6lzgbocqki.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

> Thanks! I only spotted typos this time, so I think this is ready to
> merge once we fix those.
>
> (FYI I will be OOO for the next 3 weeks or so, so don't wait on a
> response from me :))
>
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Changes since v4:
>> * I ejected the previous 10/10 to refactor "git fetch". I have more
>>   patches on top of this to do some post-refactoring (e.g. saving
>>   memory churn by getting rid of "submodule_prefix" from "struct
>>   repository"), but none of that's essential for now, so let's drop
>>   that patch.
>
> Okay, dropping the "git fetch" refactor probably makes sense in light of
> bigger refactoring.
>
> This might be premature (since the patches aren't out yet), but I'm a
> bit apprehensive about removing "submodule_prefix" from "struct
> repository". You've noted that it isn't needed right now (which I'll
> grant), but it feels taking away API features that we'll need soon™ to,
> e.g. run library functions against arbitrary repositories, some of which
> may need additional submodule information. Feel free to CC me on those
> patches, perhaps my fears will be unfounded :)

Thanks, both.  Will await for the hopefully final update.